Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify live manifests so rust-docs are default-but-optional #906

Closed
brson opened this issue Jan 6, 2017 · 6 comments
Closed

Modify live manifests so rust-docs are default-but-optional #906

brson opened this issue Jan 6, 2017 · 6 comments

Comments

@brson
Copy link
Contributor

brson commented Jan 6, 2017

Once it's possible to define components that are optional and installed by default, do so for rust-docs. Modification to rust-buildbot.

cc #905
cc https://users.rust-lang.org/t/psa-rust-documentation-is-now-optional-and-opt-in-when-installing-via-rustup/8072/20

@leonardo-m
Copy link

@kinnison
Copy link
Contributor

Does this remain desirable? Modern channels are fine, and while there are some important users who install older toolchains, I don't think it's very common these days.

@thedavidmeister
Copy link

@kinnison is what desirable? installing the docs is suuuper slow on mac and windows CI builds (about 10 minutes and can even cause timeouts), even when it doesn't time out it is very expensive for no benefit

@kinnison
Copy link
Contributor

@thedavidmeister Yes, so for modern CI you should be using --profile minimal to ensure you're not installing docs. My point was "is that sufficient, or is it a problem that on older pre-profile channels it would still be slow" ?

@thedavidmeister
Copy link

oh right, i see what you're saying

i still need to test it out, i'm using nixos so i'll have to see how this interfaces with the mozilla overlays, but it sounds great

@kinnison
Copy link
Contributor

@thedavidmeister Whenever you can, that'd be awesome. Thank you.

@kinnison kinnison closed this as completed Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants