Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving to Tokio organisation #269

Closed
Thomasdezeeuw opened this issue Oct 6, 2021 · 6 comments
Closed

Consider moving to Tokio organisation #269

Thomasdezeeuw opened this issue Oct 6, 2021 · 6 comments

Comments

@Thomasdezeeuw
Copy link
Collaborator

The Tokio organisation has offered to support the socket2 library. I'm creating this issue to have an open discussion about it.

In the past their was were some opinions against doing this, I want to know if these are still present.

/cc @Darksonn

@Darksonn
Copy link
Collaborator

Darksonn commented Oct 7, 2021

The context for this can be found in tokio#4135. We generally want to minimize the amount of distinct projects you have to trust to trust Tokio, and making socket2 part of the Tokio project will allow us to use it as a dependency without increasing that list.

@Thomasdezeeuw
Copy link
Collaborator Author

It's been a month, little to no comments. Not sure how to interpret that.

@rust-lang/libs team how do you feel?

@robjtede
Copy link

robjtede commented Nov 9, 2021

I think that the Rust community would, buy-and-large, trust any project that the Rust compiler itself sits in (ie. rust-lang). Socket2 feels like a project that has a wider scope than Tokio since it is more general in purpose. I would be surprised, even, to discover that such a project resides in Tokio's org.

@taiki-e
Copy link
Member

taiki-e commented Nov 23, 2021

I believe that what is proposed in RFC3119 "Rust crate ownership policy" (merged a few months ago) is enough to address (most of?) the original concerns from the tokio team, but it is not clear how long it will take to do.

@Thomasdezeeuw
Copy link
Collaborator Author

I believe that what is proposed in RFC3119 "Rust crate ownership policy" (merged a few months ago) is enough to address (most of?) the original concerns from the tokio team, but it is not clear how long it will take to do.

The problem with RFC3119 is that I haven't seen a lot work being done in the area. I think generally people like the idea, but I'm not sure how time is spend actually implementing it all, as per the (lack of) comments on the tracking issue: rust-lang/rust#88867.

For I think the plan is to not move socket2 and instead invite some maintainers from Tokio to this repo.

@Thomasdezeeuw
Copy link
Collaborator Author

Closing this as we're not moving the socket2 crate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants