Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding DCCP support #350

Closed
onestay opened this issue Sep 20, 2022 · 3 comments
Closed

Adding DCCP support #350

onestay opened this issue Sep 20, 2022 · 3 comments

Comments

@onestay
Copy link
Contributor

onestay commented Sep 20, 2022

I would like to add DCCP support. It is currently only available on Linux. It would basically only involve exposing the Type, Protocol and some socket options listed here. Would this be something of interest?

Currently I'm proposing to just add something like this

    #[cfg(target_os = "linux")]
    /// Type corresponding to `SOCK_DCCP`
    /// 
    /// Used for the DCCP protocol
    pub const DCCP: Type = Type(sys::SOCK_DCCP);

and

#[cfg(target_os = "linux")]
    /// Protocol corresponding to `DCCP`
    pub const DCCP: Protocol = Protocol(sys::IPPROTO_DCCP);

In addition I'd propose adding the socket options prefixed with dccp_. So for example the socket option DCCP_SOCKOPT_SERVICE could be dccp_set_service() and dccp_service()

@Thomasdezeeuw
Copy link
Collaborator

Sounds good 👍

@dtaht dtaht mentioned this issue Dec 11, 2022
@Thomasdezeeuw
Copy link
Collaborator

@onestay can this be closed after #359 was merged?

@onestay
Copy link
Contributor Author

onestay commented Apr 5, 2023

Oh, yeah of course. Sorry, totally forgot.

@onestay onestay closed this as completed Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants