Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on an external git repository #1255

Closed
jethrogb opened this issue Nov 17, 2021 · 2 comments
Closed

Dependency on an external git repository #1255

jethrogb opened this issue Nov 17, 2021 · 2 comments

Comments

@jethrogb
Copy link
Contributor

This repository, which is part of the Rust project, now depends on a git repository which is not part of the Rust project through a submodule. This means the Rust project is now dependent on the correct management of that 3rd party of their repo (such as that the commits are indefinitely maintained in one of the branches) or the Rust project will fail to build. It's not clear to me that this implication was considered during the merge of #1237

@Amanieu
Copy link
Member

Amanieu commented Nov 20, 2021

This submodule is only used by a test tool in stdarch's CI. If this is still a concern, we could just take the csv from that submodule and included directly in the repo.

@CatsAreFluffy
Copy link

The submodule was removed in #1427, so I think this can be closed now.

@Amanieu Amanieu closed this as completed Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants