You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, System as AllocRef calls the GlobalAlloc implementation. GlobalAlloc for System is implemented in std::sys::*::alloc.
I'd like to swap this for two reasons:
AllocRef has more methods like grow_in_place. At least dlmalloc supports this.
By name, System makes more sense to be implemented in std::sys::*::alloc.
The text was updated successfully, but these errors were encountered:
As an end-goal, I think we will want to completely replace GlobalAlloc with AllocRef (i.e. #[global_allocator] requires AllocRef instead of GlobalAlloc). This is discussed in more detail in #21. As part of this we will provide a "compatibility wrapper" of impl AllocRef for T where T: GlobalAlloc which implements AllocRef using the GlobalAlloc methods.
So basically, I am in favor of this change since it moves us towards the direction of AllocRef being the "primary" implementation for System.
I think that we should wait with this change until #38, #41, and #42 are merged (I expect this), otherwise I have to change many files on every push. Falling back to GlobalAlloc is currently quiet convenient.
Currently,
System as AllocRef
calls theGlobalAlloc
implementation.GlobalAlloc
forSystem
is implemented instd::sys::*::alloc
.I'd like to swap this for two reasons:
AllocRef
has more methods likegrow_in_place
. At leastdlmalloc
supports this.System
makes more sense to be implemented instd::sys::*::alloc
.The text was updated successfully, but these errors were encountered: