Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider switching the thread RNG to OsRng #78

Closed
pcwalton opened this issue Sep 15, 2015 · 3 comments
Closed

Consider switching the thread RNG to OsRng #78

pcwalton opened this issue Sep 15, 2015 · 3 comments
Labels
E-question Participation: opinions wanted

Comments

@pcwalton
Copy link
Contributor

I think we should not be encouraging ISAAC. The documentation even cautions against its use.

I know the compiler will get slow if you switch away from ISAAC, but we should just manually use ISAAC in the compiler if we really need that. Userspace CSPRNGs are bad.

@zackw
Copy link

zackw commented Sep 15, 2015

ChaCha instead maybe?

@arthurprs
Copy link
Contributor

Wouldn't that be order of magnitudes slower?

@alexcrichton alexcrichton added the E-question Participation: opinions wanted label Jun 14, 2017
@dhardy
Copy link
Member

dhardy commented Dec 8, 2017

I don't think switching thread_rng to OsRng is the right choice (it's been discussed; thread_rng or rather an equivalent is used for seeding HashMap's hash function and is designed as a fast, reasonably strong generator).

On the other hand we may increase thread_rng to full crypto strength: dhardy#53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-question Participation: opinions wanted
Projects
None yet
Development

No branches or pull requests

5 participants