Switch to using the pki-types crate #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpu
approved these changes
Aug 30, 2023
djc
commented
Aug 31, 2023
| _ => {} | ||
| }; | ||
| } | ||
| pub fn certs( |
There was a problem hiding this comment.
FWIW, these changes worked out well in the rustls tests.
ctz
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For more context, see rustls/pki-types#1.
This adjusts the
Itemvariant names to match the names used in pki-types (and make the names comply with the API naming guidelines).I also tacked on a change to yield
impl Iteratortypes from the various helper functions instead of allocating aVecdirectly. This is maybe more efficient but may not pull off its weight in extra API complexity vs how this API gets used?One option here would be to bring this functionality into rustls-pki-types directly under an extra feature flag (or perhaps unconditionally with a small internal base64 implementation, compared to the current dependency with aggressively-ish MSRV that is under not-so-great management).