Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pki-types pem decoding #55

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Use pki-types pem decoding #55

merged 2 commits into from
Sep 30, 2024

Conversation

ctz
Copy link
Member

@ctz ctz commented Sep 18, 2024 •
edited
Loading

I was hoping to rely on cargo-semver-checks here to check for API regressions, alas obi1kenobi/cargo-semver-checks#609 means this is not possible.

@ctz ctz mentioned this pull request Sep 18, 2024
Merged
djc
djc reviewed Sep 18, 2024
View reviewed changes
Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool!

src/pemfile.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/pemfile.rs Outdated Show resolved Hide resolved
src/pemfile.rs Outdated Show resolved Hide resolved
src/pemfile.rs Outdated Show resolved Hide resolved
cpu
cpu reviewed Sep 18, 2024
View reviewed changes
src/pemfile.rs Outdated Show resolved Hide resolved
src/pemfile.rs Show resolved Hide resolved
src/pemfile.rs Outdated Show resolved Hide resolved
@ctz ctz force-pushed the jbp-use-pki-types-pem branch from f44babd to 77351f4 Compare September 25, 2024 12:22
@ctz
Copy link
Member Author

ctz commented Sep 25, 2024

I was hoping to rely on cargo-semver-checks here to check for API regressions, alas obi1kenobi/cargo-semver-checks#609 means this is not possible.

Now Item is back in this crate, this now works again and confirms (to the extent it can) there are no breaking changes.

djc
djc approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, this seems to work out well?

I'm assuming you'll just squash all the commits here?

src/pemfile.rs Outdated Show resolved Hide resolved
@ctz ctz force-pushed the jbp-use-pki-types-pem branch from 77351f4 to 1e62bbb Compare September 25, 2024 12:46
cpu
cpu approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 👍

@ctz ctz force-pushed the jbp-use-pki-types-pem branch from 66eff48 to 6a0f0fe Compare September 27, 2024 15:57
@ctz ctz marked this pull request as ready for review September 27, 2024 15:58
djc
djc approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ctz ctz merged commit f5d49b2 into main Sep 30, 2024
18 checks passed
@ctz ctz deleted the jbp-use-pki-types-pem branch September 30, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpu cpu cpu approved these changes

@djc djc djc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctz @djc @cpu