From 24d0005a893402dddf803f82e1f472d9c997c06b Mon Sep 17 00:00:00 2001 From: niluxv Date: Fri, 4 Nov 2022 20:57:35 +0100 Subject: [PATCH] Add `atty` potential unsoundness (unaligned read) advisory --- crates/atty/RUSTSEC-0000-0000.md | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 crates/atty/RUSTSEC-0000-0000.md diff --git a/crates/atty/RUSTSEC-0000-0000.md b/crates/atty/RUSTSEC-0000-0000.md new file mode 100644 index 000000000..6408ddcba --- /dev/null +++ b/crates/atty/RUSTSEC-0000-0000.md @@ -0,0 +1,21 @@ +```toml +[advisory] +id = "RUSTSEC-0000-0000" +package = "atty" +date = "2021-07-04" +url = "https://github.com/softprops/atty/issues/50" +keywords = ["unaligned-read"] +informational = "unsound" + +[affected] +os = ["windows"] + +[versions] +patched = [] +``` + +# Potential unaligned read + +On windows, `atty` dereferences a potentially unaligned pointer. +In practice however, the pointer won't be unaligned unless a custom global allocator is used. +In particular, the `System` allocator on windows uses `HeapAlloc`, which guarantees a large enough alignment.