request-animation-frame $ cargo clippy Compiling wasm-bindgen-backend v0.2.33 (/Users/misakimakino/Works/clones/fork-wasm-bindgen/wasm-bindgen/crates/backend) Compiling wasm-bindgen-macro-support v0.2.33 (/Users/misakimakino/Works/clones/fork-wasm-bindgen/wasm-bindgen/crates/macro-support) Compiling wasm-bindgen-webidl v0.2.27 (/Users/misakimakino/Works/clones/fork-wasm-bindgen/wasm-bindgen/crates/webidl) Compiling wasm-bindgen-macro v0.2.33 (/Users/misakimakino/Works/clones/fork-wasm-bindgen/wasm-bindgen/crates/macro) Compiling web-sys v0.3.10 (/Users/misakimakino/Works/clones/fork-wasm-bindgen/wasm-bindgen/crates/web-sys) Checking wasm-bindgen v0.2.33 (/Users/misakimakino/Works/clones/fork-wasm-bindgen/wasm-bindgen) warning: long literal lacking separators --> src/convert/impls.rs:137:32 | 137 | fn none() -> u32 { 0xFFFFFFu32 } | ^^^^^^^^^^^ help: consider: `0x00FF_FFFFu32` ... 147 | type_abi_as_u32!(i8 u8 i16 u16); | -------------------------------- in this macro invocation | = note: #[warn(clippy::unreadable_literal)] on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal warning: long literal lacking separators --> src/convert/impls.rs:142:51 | 142 | fn is_none(js: &u32) -> bool { *js == 0xFFFFFFu32 } | ^^^^^^^^^^^ help: consider: `0x00FF_FFFFu32` ... 147 | type_abi_as_u32!(i8 u8 i16 u16); | -------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal warning: long literal lacking separators --> src/convert/impls.rs:137:32 | 137 | fn none() -> u32 { 0xFFFFFFu32 } | ^^^^^^^^^^^ help: consider: `0x00FF_FFFFu32` ... 147 | type_abi_as_u32!(i8 u8 i16 u16); | -------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal warning: long literal lacking separators --> src/convert/impls.rs:232:9 | 232 | 0xFFFFFFu32 | ^^^^^^^^^^^ help: consider: `0x00FF_FFFFu32` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal warning: long literal lacking separators --> src/convert/impls.rs:239:16 | 239 | *js == 0xFFFFFFu32 | ^^^^^^^^^^^ help: consider: `0x00FF_FFFFu32` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal warning: unneeded return statement --> src/convert/impls.rs:331:9 | 331 | return ret; | ^^^^^^^^^^^ help: remove `return` as shown: `ret` | = note: #[warn(clippy::needless_return)] on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return warning: unneeded unit return type --> src/convert/impls.rs:406:43 | 406 | fn into_abi(self, _extra: &mut Stack) -> () { | ^^^^^ help: remove the `-> ()` | = note: #[warn(clippy::unused_unit)] on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit warning: casting function pointer `$invoke::<$($var,)* R>` to `u32`, which truncates the value --> src/convert/closures.rs:52:24 | 52 | inform($invoke::<$($var,)* R> as u32); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `$invoke::<$($var,)* R> as usize` ... 110 | / stack_closures! { 111 | | (0 invoke0 invoke0_mut) 112 | | (1 invoke1 invoke1_mut A) 113 | | (2 invoke2 invoke2_mut A B) ... | 118 | | (7 invoke7 invoke7_mut A B C D E F G) 119 | | } | |_- in this macro invocation | = note: #[warn(clippy::fn_to_numeric_cast_with_truncation)] on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#fn_to_numeric_cast_with_truncation warning: casting function pointer `$invoke_mut::<$($var,)* R>` to `u32`, which truncates the value --> src/convert/closures.rs:101:24 | 101 | inform($invoke_mut::<$($var,)* R> as u32); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `$invoke_mut::<$($var,)* R> as usize` ... 110 | / stack_closures! { 111 | | (0 invoke0 invoke0_mut) 112 | | (1 invoke1 invoke1_mut A) 113 | | (2 invoke2 invoke2_mut A B) ... | 118 | | (7 invoke7 invoke7_mut A B C D E F G) 119 | | } | |_- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#fn_to_numeric_cast_with_truncation warning: casting function pointer `$invoke::<$($var,)* R>` to `u32`, which truncates the value --> src/convert/closures.rs:52:24 | 52 | inform($invoke::<$($var,)* R> as u32); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `$invoke::<$($var,)* R> as usize` ... 110 | / stack_closures! { 111 | | (0 invoke0 invoke0_mut) 112 | | (1 invoke1 invoke1_mut A) 113 | | (2 invoke2 invoke2_mut A B) ... | 118 | | (7 invoke7 invoke7_mut A B C D E F G) 119 | | } | |_- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#fn_to_numeric_cast_with_truncation warning: casting i32 to f64 may become silently lossy if types change --> src/convert/impls.rs:85:32 | 85 | value: 0 as $c, | ^ help: try: `f64::from(0)` ... 110 | / type_wasm_native!( 111 | | i32 as i32 => WasmOptionalI32 112 | | isize as i32 => WasmOptionalI32 113 | | u32 as u32 => WasmOptionalU32 ... | 116 | | f64 as f64 => WasmOptionalF64 117 | | ); | |__- in this macro invocation | = note: #[warn(clippy::cast_lossless)] on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless warning: casting u8 to u32 may become silently lossy if types change --> src/convert/impls.rs:125:60 | 125 | fn into_abi(self, _extra: &mut Stack) -> u32 { self as u32 } | ^^^^^^^^^^^ help: try: `u32::from(self)` ... 147 | type_abi_as_u32!(i8 u8 i16 u16); | -------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless warning: casting u16 to u32 may become silently lossy if types change --> src/convert/impls.rs:125:60 | 125 | fn into_abi(self, _extra: &mut Stack) -> u32 { self as u32 } | ^^^^^^^^^^^ help: try: `u32::from(self)` ... 147 | type_abi_as_u32!(i8 u8 i16 u16); | -------------------------------- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless warning: casting u32 to i64 may become silently lossy if types change --> src/convert/impls.rs:168:17 | 168 | (js.low as $t) | ((js.high as $t) << 32) | ^^^^^^^^^^^^^^ help: try: `i64::from(js.low)` ... 209 | type_64!(i64 u64); | ------------------ in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless warning: casting u32 to i64 may become silently lossy if types change --> src/convert/impls.rs:168:35 | 168 | (js.low as $t) | ((js.high as $t) << 32) | ^^^^^^^^^^^^^^^ help: try: `i64::from(js.high)` ... 209 | type_64!(i64 u64); | ------------------ in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless warning: casting u32 to i64 may become silently lossy if types change --> src/convert/impls.rs:202:26 | 202 | Some((js.low as $t) | ((js.high as $t) << 32)) | ^^^^^^^^^^^^^^ help: try: `i64::from(js.low)` ... 209 | type_64!(i64 u64); | ------------------ in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless warning: casting u32 to i64 may become silently lossy if types change --> src/convert/impls.rs:202:44 | 202 | Some((js.low as $t) | ((js.high as $t) << 32)) | ^^^^^^^^^^^^^^^ help: try: `i64::from(js.high)` ... 209 | type_64!(i64 u64); | ------------------ in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless warning: casting u32 to u64 may become silently lossy if types change --> src/convert/impls.rs:168:17 | 168 | (js.low as $t) | ((js.high as $t) << 32) | ^^^^^^^^^^^^^^ help: try: `u64::from(js.low)` ... 209 | type_64!(i64 u64); | ------------------ in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless warning: casting u32 to u64 may become silently lossy if types change --> src/convert/impls.rs:168:35 | 168 | (js.low as $t) | ((js.high as $t) << 32) | ^^^^^^^^^^^^^^^ help: try: `u64::from(js.high)` ... 209 | type_64!(i64 u64); | ------------------ in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless warning: casting u32 to u64 may become silently lossy if types change --> src/convert/impls.rs:202:26 | 202 | Some((js.low as $t) | ((js.high as $t) << 32)) | ^^^^^^^^^^^^^^ help: try: `u64::from(js.low)` ... 209 | type_64!(i64 u64); | ------------------ in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless warning: casting u32 to u64 may become silently lossy if types change --> src/convert/impls.rs:202:44 | 202 | Some((js.low as $t) | ((js.high as $t) << 32)) | ^^^^^^^^^^^^^^^ help: try: `u64::from(js.high)` ... 209 | type_64!(i64 u64); | ------------------ in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless warning: use of `offset` with a `usize` casted to an `isize` --> src/convert/mod.rs:29:14 | 29 | *global_ptr().offset(self.next as isize) = val; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `global_ptr().add(self.next)` | = note: #[warn(clippy::ptr_offset_with_cast)] on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast warning: casting function pointer `describe::` to `u32`, which truncates the value --> src/closure.rs:204:17 | 204 | describe:: as u32, | ^^^^^^^^^^^^^^^^^^^^ help: try: `describe:: as usize` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#fn_to_numeric_cast_with_truncation warning: casting function pointer `invoke::<$($var,)* R>` to `u32`, which truncates the value --> src/closure.rs:342:24 | 342 | inform(invoke::<$($var,)* R> as u32); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `invoke::<$($var,)* R> as usize` ... 408 | / doit! { 409 | | () 410 | | (A) 411 | | (A B) ... | 416 | | (A B C D E F G) 417 | | } | |_- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#fn_to_numeric_cast_with_truncation warning: casting function pointer `destroy::<$($var,)* R>` to `u32`, which truncates the value --> src/closure.rs:353:24 | 353 | inform(destroy::<$($var,)* R> as u32); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `destroy::<$($var,)* R> as usize` ... 408 | / doit! { 409 | | () 410 | | (A) 411 | | (A B) ... | 416 | | (A B C D E F G) 417 | | } | |_- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#fn_to_numeric_cast_with_truncation warning: casting function pointer `invoke::<$($var,)* R>` to `u32`, which truncates the value --> src/closure.rs:389:24 | 389 | inform(invoke::<$($var,)* R> as u32); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `invoke::<$($var,)* R> as usize` ... 408 | / doit! { 409 | | () 410 | | (A) 411 | | (A B) ... | 416 | | (A B C D E F G) 417 | | } | |_- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#fn_to_numeric_cast_with_truncation warning: casting function pointer `destroy::<$($var,)* R>` to `u32`, which truncates the value --> src/closure.rs:400:24 | 400 | inform(destroy::<$($var,)* R> as u32); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `destroy::<$($var,)* R> as usize` ... 408 | / doit! { 409 | | () 410 | | (A) 411 | | (A B) ... | 416 | | (A B C D E F G) 417 | | } | |_- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#fn_to_numeric_cast_with_truncation warning: the operation is ineffective. Consider reducing it to `JSIDX_OFFSET` --> src/lib.rs:74:30 | 74 | const JSIDX_UNDEFINED: u32 = JSIDX_OFFSET + 0; | ^^^^^^^^^^^^^^^^ | = note: #[warn(clippy::identity_op)] on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name --> src/lib.rs:118:5 | 118 | / pub fn from_str(s: &str) -> JsValue { 119 | | unsafe { JsValue::_new(__wbindgen_string_new(s.as_ptr(), s.len())) } 120 | | } | |_____^ | = note: #[warn(clippy::should_implement_trait)] on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait Checking js-sys v0.3.10 (/Users/misakimakino/Works/clones/fork-wasm-bindgen/wasm-bindgen/crates/js-sys) error: attributes are not yet allowed on `if` expressions --> crates/js-sys/src/lib.rs:49:1 | 49 | #[wasm_bindgen] | ^^^^^^^^^^^^^^^ error: attributes are not yet allowed on `if` expressions --> crates/js-sys/src/lib.rs:954:1 | 954 | #[wasm_bindgen] | ^^^^^^^^^^^^^^^ error: attributes are not yet allowed on `if` expressions --> crates/js-sys/src/lib.rs:1061:1 | 1061 | #[wasm_bindgen] | ^^^^^^^^^^^^^^^ error: attributes are not yet allowed on `if` expressions --> crates/js-sys/src/lib.rs:1444:1 | 1444 | #[wasm_bindgen] | ^^^^^^^^^^^^^^^ error: attributes are not yet allowed on `if` expressions --> crates/js-sys/src/lib.rs:1846:1 | 1846 | #[wasm_bindgen] | ^^^^^^^^^^^^^^^ error: attributes are not yet allowed on `if` expressions --> crates/js-sys/src/lib.rs:2595:1 | 2595 | #[wasm_bindgen] | ^^^^^^^^^^^^^^^ error: attributes are not yet allowed on `if` expressions --> crates/js-sys/src/lib.rs:3499:5 | 3499 | #[wasm_bindgen] | ^^^^^^^^^^^^^^^ error: attributes are not yet allowed on `if` expressions --> crates/js-sys/src/lib.rs:3564:5 | 3564 | #[wasm_bindgen] | ^^^^^^^^^^^^^^^ error: attributes are not yet allowed on `if` expressions --> crates/js-sys/src/lib.rs:3638:5 | 3638 | #[wasm_bindgen] | ^^^^^^^^^^^^^^^ error: attributes are not yet allowed on `if` expressions --> crates/js-sys/src/lib.rs:3681:5 | 3681 | #[wasm_bindgen] | ^^^^^^^^^^^^^^^ error: attributes are not yet allowed on `if` expressions --> crates/js-sys/src/lib.rs:3730:5 | 3730 | #[wasm_bindgen] | ^^^^^^^^^^^^^^^ error: attributes are not yet allowed on `if` expressions --> crates/js-sys/src/lib.rs:3769:1 | 3769 | #[wasm_bindgen] | ^^^^^^^^^^^^^^^ error: attributes are not yet allowed on `if` expressions --> crates/js-sys/src/lib.rs:3832:1 | 3832 | #[wasm_bindgen] | ^^^^^^^^^^^^^^^ error: aborting due to 13 previous errors error: Could not compile `js-sys`. warning: build failed, waiting for other jobs to finish... error: build failed request-animation-frame $