Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Passing a SharedArrayBuffer to DataView #3694

Closed
kyledecot opened this issue Nov 9, 2023 · 0 comments · Fixed by #3695
Closed

Support Passing a SharedArrayBuffer to DataView #3694

kyledecot opened this issue Nov 9, 2023 · 0 comments · Fixed by #3695
Labels
enhancement

Comments

@kyledecot
Copy link
Contributor

kyledecot commented Nov 9, 2023 •
edited
Loading

Motivation

Modern browsers allow a regular ArrayBuffer as well as a SharedArrayBuffer to be passed to the constructor of DataView. Currently, the wasm-bindgen version DataView allow only a ArrayBuffer to be passed.

See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/DataView/DataView#buffer

Proposed Solution

Update the implementation of DataView to accept a &JsValue instead of a &ArrayBuffer.

Alternatives

N/A

Additional Context

N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow SharedArrayBuffer to be passed to DataView constructor kyledecot/wasm-bindgen
1 participant
@kyledecot