-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish a wasm-bindgen-test
for use as an internal detail within wasm-pack test
#615
Comments
And here is the |
So I followed the steps here https://github.com/rustwasm/wasm-bindgen/blob/master/crates/test/README.md And got the following error: https://gist.github.com/gnzlbg/bce2a1020dde236e28d466311e4697c8 = note: rust-lld: error: duplicate symbol: __wbindgen_global_argument_ptr
>>> defined in /wasm-test/target/wasm32-unknown-unknown/debug/deps/libwasm_bindgen-93b4abe9cd9b46f4.rlib(wasm_bindgen-93b4abe9cd9b46f4.wasm_bindgen13.rcgu.o)
>>> defined in /wasm-test/target/wasm32-unknown-unknown/debug/deps/libwasm_bindgen-1267805b2935233b.rlib(wasm_bindgen-1267805b2935233b.wasm_bindgen4.rcgu.o)
rust-lld: error: duplicate symbol: __wbindgen_malloc
>>> defined in /wasm-test/target/wasm32-unknown-unknown/debug/deps/libwasm_bindgen-93b4abe9cd9b46f4.rlib(wasm_bindgen-93b4abe9cd9b46f4.wasm_bindgen13.rcgu.o)
>>> defined in /wasm-test/target/wasm32-unknown-unknown/debug/deps/libwasm_bindgen-1267805b2935233b.rlib(wasm_bindgen-1267805b2935233b.wasm_bindgen4.rcgu.o)
rust-lld: error: duplicate symbol: __wbindgen_free
>>> defined in /wasm-test/target/wasm32-unknown-unknown/debug/deps/libwasm_bindgen-93b4abe9cd9b46f4.rlib(wasm_bindgen-93b4abe9cd9b46f4.wasm_bindgen13.rcgu.o)
>>> defined in /wasm-test/target/wasm32-unknown-unknown/debug/deps/libwasm_bindgen-1267805b2935233b.rlib(wasm_bindgen-1267805b2935233b.wasm_bindgen4.rcgu.o) System is MacOSX 10.13.6 My [package]
name = "wasm-test"
version = "0.1.0"
authors = ["..."]
[target.'cfg(target_arch = "wasm32")'.dev-dependencies]
wasm-bindgen-test = { git = 'https://github.com/rustwasm/wasm-bindgen' } and in my [target.wasm32-unknown-unknown]
runner = 'wasm-bindgen-test-runner' My |
Yes, @fitzgen was very helpful on IRC, thanks! |
could we do a wasm-bindgen minor release to avoid using this from git ? |
Yes, hopefully today or tomorrow. |
0.2.16 is published! |
I think we can close this issue -- I didn't realize that we had already published |
As discussed in today's WG meeting, we are aiming for publishing an initial release of the
wasm-bindgen-test
crate to be used as an unstable implementation detail within awasm-pack test
command for the Rust 2018 Release Candidate milestone. That's 6 weeks from now: 2018-09-13.What needs to be done before we publish
wasm-bindgen-test
for use bywasm-pack test
?+cc @alexcrichton @ashleygwilliams
The text was updated successfully, but these errors were encountered: