Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JsString <-> char conversions #1473

Merged
merged 2 commits into from
Apr 24, 2019
Merged

Add JsString <-> char conversions #1473

merged 2 commits into from
Apr 24, 2019

Commits on Apr 23, 2019

  1. Add JsString <-> char conversions 

    These are pretty common and already supported via ABI conversions, yet pretty easy to get wrong when converting them manually.

Fixes rustwasm#1363.
    @RReverser
    RReverser committed Apr 23, 2019
    Configuration menu
    Copy the full SHA
    bc4a98d View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2019

  1. Remove PartialEq<char> for JsString for now 

    This seems to spark controversy, so removing for now but should be easy enough to still add in the future.
    @RReverser
    RReverser committed Apr 24, 2019
    Configuration menu
    Copy the full SHA
    680a6bb View commit details
    Browse the repository at this point in the history