Removing self from no-modules target #1995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
migerh
added a commit
to migerh/rustwasm-gif
that referenced
this pull request
Oct 20, 2022
This requires manual patching of the gif.js output now. With rustwasm/wasm-bindgen#1995 the `self.` prefix was removed from the JS wrapper output. This means it will no longer properly inject the wasm_bindgen wrapper code into the WebWorker context. To fix this for now follow these steps: * Remove the first line that declares wasm_bindgen * Add `self.` in front of `wasm_bindgen` definition at the end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some JS targets don't have
self, so this removesselffrom theno-modulestarget.The behavior should be the same, it still creates a global
wasm_bindgenvariable and assigns to it.This is accomplished by creating the variable outside of the function and then assigning to it inside the function.