Add a --reference-types CLI flag
#2257
Conversation
This proposal is now shipping in browsers!
| let stack_pointer = 32; | ||
|
|
||
| function addBorrowedObject(obj) { | ||
| if (stack_pointer == 1) throw new Error('out of js stack'); |
There was a problem hiding this comment.
Hey quick question.
How come this isn't if (stack_pointer == 0)?
What's the issue with assigning an object to heap[0].
Just for my own understanding.
Thanks!
There was a problem hiding this comment.
I think at some point we were reserving the first slot (index 0) as a sort of null pointer or something like that. I don't believe those plans ever panned out though so this is likely a bug that we can fix nowadays.
There was a problem hiding this comment.
Sweet thanks for explaining!
|
Hello @alexcrichton 👋 Sorry if this question is unrelated, but how can I enable this option with I've tried to add following to my [package.metadata.wasm-pack.profile.release.wasm-bindgen]
reference-types = true |
|
Sorry I'm not faimliar enough with wasm-pack to know how to pass this argument. This may need a patch to wasm-bindgen. |
|
@Urhengulas There is an open PR which adds the |
This proposal is now shipping in browsers!