Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled and auto generated forget() method for UsbDevice #3821

Merged
merged 3 commits into from
Feb 2, 2024

Conversation

G2-Games
Copy link
Contributor

@G2-Games G2-Games commented Feb 2, 2024

This will allow the user to forget a device which has been "trusted" or "remembered" by the browser.

As defined here: https://developer.mozilla.org/en-US/docs/Web/API/USBDevice/forget

Apologies for my earlier erroneous pull request.

Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
But missing a changelog entry.

@G2-Games
Copy link
Contributor Author

G2-Games commented Feb 2, 2024

I added something, is that sufficient?

CHANGELOG.md Outdated Show resolved Hide resolved
@daxpedda daxpedda merged commit 1f019db into rustwasm:main Feb 2, 2024
15 checks passed
@daxpedda
Copy link
Collaborator

daxpedda commented Feb 2, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants