Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WebIDL definitions relating to Popover API. #3977

Merged
merged 1 commit into from
Jul 28, 2024
Merged

Add WebIDL definitions relating to Popover API. #3977

merged 1 commit into from
Jul 28, 2024

Conversation

CathalMullan
Copy link
Contributor

@CathalMullan CathalMullan commented Jun 6, 2024 •
edited
Loading

Add/update definitions to support the Popover API.

Relevant WebIDL sources here.

@CathalMullan CathalMullan marked this pull request as ready for review June 6, 2024 15:46
daxpedda
daxpedda requested changes Jul 28, 2024
View reviewed changes
Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the huge delay!
LGTM except the small nit.

crates/web-sys/webidls/enabled/EventHandler.webidl Show resolved Hide resolved
@daxpedda daxpedda merged commit ae2d76a into rustwasm:main Jul 28, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxpedda daxpedda daxpedda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CathalMullan @daxpedda