Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test using assert_cli #18

Closed
ashleygwilliams opened this issue Mar 2, 2018 · 7 comments
Closed

test using assert_cli #18

ashleygwilliams opened this issue Mar 2, 2018 · 7 comments
Labels
priority to-do stuff that needs to happen, so plz do it k thx

Comments

@ashleygwilliams
Copy link
Member

https://github.com/killercup/assert_cli
@ashleygwilliams ashleygwilliams added the to-do stuff that needs to happen, so plz do it k thx label Mar 2, 2018
@ashleygwilliams ashleygwilliams added this to the 0.1.0 milestone Mar 4, 2018
@yoshuawuyts
Copy link
Contributor

I was thinking dir-diff might be a good one too for the output. E.g. https://github.com/ashleygwilliams/wasm-pack/pull/32 doesn't have any tests, but using dirdiff, it should be quite convenient to test the output.

@ashleygwilliams
Copy link
Member Author

@yoshuawuyts yeah! i am speaking to some of the CLI-WG team on gitter and they suggested that as well. are you interested in tackling any of this testing? i could do it on my own but since you've taken some interest, i'm super down to let you take a crack at it if you'd like!

@yoshuawuyts yoshuawuyts mentioned this issue Mar 6, 2018
Merged
@yoshuawuyts
Copy link
Contributor

@ashleygwilliams done!

@mgattozzi mgattozzi mentioned this issue Mar 14, 2018
Closed
@ashleygwilliams ashleygwilliams added the PR attached there's a PR open for this issue label Mar 14, 2018
@ashleygwilliams ashleygwilliams removed the PR attached there's a PR open for this issue label Apr 4, 2018
@ashleygwilliams
Copy link
Member Author

this has some issue with windows compat!

@ashleygwilliams ashleygwilliams removed this from the 0.1.0 milestone Apr 18, 2018
@ashleygwilliams
Copy link
Member Author

after a regression in 0.3.0 this is top priority now

@ashleygwilliams ashleygwilliams added this to the 0.4.0 milestone Jun 5, 2018
@ashleygwilliams ashleygwilliams mentioned this issue Jun 5, 2018
Closed
@mgattozzi
Copy link
Contributor

Have been working on this, but also have been a bit busy. If someone is really eager to do this I'm happy to point them exactly on how to do it if they want to claim it. Otherwise for now I'll keep at it.

@ashleygwilliams ashleygwilliams modified the milestones: 0.4.0, 0.5.0 Jun 18, 2018
@ashleygwilliams ashleygwilliams modified the milestones: 0.5.0, 0.6.0 Oct 1, 2018
@fitzgen fitzgen mentioned this issue Nov 5, 2018
Closed
@ashleygwilliams ashleygwilliams modified the milestones: 0.6.0, 0.7.0 Dec 27, 2018
@ashleygwilliams
Copy link
Member Author

@fitzgen handled this with #522 closing

@ashleygwilliams ashleygwilliams removed this from the 0.8.0 milestone Feb 21, 2019
@Kerosin3 Kerosin3 mentioned this issue Jan 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority to-do stuff that needs to happen, so plz do it k thx
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fitzgen @ashleygwilliams @yoshuawuyts @mgattozzi