Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing wasm-bindgen tool is non obvious #46

Closed
mgattozzi opened this issue Mar 9, 2018 · 3 comments
Closed

Installing wasm-bindgen tool is non obvious #46

mgattozzi opened this issue Mar 9, 2018 · 3 comments
Labels
to-do stuff that needs to happen, so plz do it k thx
Milestone

Comments

@mgattozzi
Copy link
Contributor

When first running wasm-pack there's no indication that wasm-bindgen is being installed at first. I had a huge spike in CPU usage and was confused why it happened the first time I ran the command. It wasn't until looking in the code for something that I saw why.

If this is the first time then we should print out that it will be compiled and installed. If it's not and it exists and the version is not outdated we should print out that it's already installed. If it's installed and outdated we should print out that we're updating it.

@ashleygwilliams ashleygwilliams added the to-do stuff that needs to happen, so plz do it k thx label Mar 9, 2018
@ashleygwilliams
Copy link
Member

now that i've merged #49 i'm curious if you think this is ok now? i've made it clear that one step is installing wasm-bindgen and i've filed #51 to eventually account for not taking that step if we don't need to

@ashleygwilliams ashleygwilliams added this to the 0.1.0 milestone Mar 13, 2018
@mgattozzi
Copy link
Contributor Author

@ashleygwilliams I'll need to run this tomorrow at some point. Will let you know!

@mgattozzi
Copy link
Contributor Author

This looks good to me! I think we can definitely follow up with #51 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
to-do stuff that needs to happen, so plz do it k thx
Projects
None yet
Development

No branches or pull requests

2 participants