Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo command calls don't output color to the terminal #480

Closed
evaporei opened this issue Jan 3, 2019 · 3 comments
Closed

Cargo command calls don't output color to the terminal #480

evaporei opened this issue Jan 3, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@evaporei
Copy link

evaporei commented Jan 3, 2019

💡 Feature description

When wasm-pack runs cargo build for example, under the hood, the output of it has no color.

💻 Basic example

In the image down below, this part should have color just like using cargo build directly on the terminal.
screenshot from 2019-01-03 19-55-23

Part without color:

  [4/9] Compiling to WASM...
      Finished release [optimized] target(s) in 0.04s

I honestly would like to have color because it eases to understand errors on the terminal 🙂

Example of error without color:

screenshot from 2019-01-03 20-55-41

Example with color:

screenshot from 2019-01-03 20-57-06

@ashleygwilliams ashleygwilliams added this to the 0.6.0 milestone Jan 3, 2019
@ashleygwilliams ashleygwilliams added PR attached there's a PR open for this issue enhancement New feature or request labels Jan 3, 2019
@ashleygwilliams ashleygwilliams removed the PR attached there's a PR open for this issue label Jan 11, 2019
@ashleygwilliams ashleygwilliams removed this from the 0.6.0 milestone Jan 11, 2019
@ibaryshnikov
Copy link
Member

is it still an issue? @otaviopace @ashleygwilliams
wasm-pack output for current version (0.8.1) is colored enough, it looks like it was fixed in one of the releases

@evaporei
Copy link
Author

evaporei commented Jul 4, 2019

Honestly I don't know because I don't have that computer anymore 😕 . Maybe we can close the issue, and later if I or anyone suffers from it, we can re open it.

@ashleygwilliams
Copy link
Member

closing- sorry to hear about your computer @otaviopace ! please file a new issue if this is still a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants