Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help message for wasm-pack build is not updated #636

Closed
ibaryshnikov opened this issue Apr 29, 2019 · 3 comments
Closed

Help message for wasm-pack build is not updated #636

ibaryshnikov opened this issue Apr 29, 2019 · 3 comments
Assignees
Labels
bug Something isn't working current release current todo items PR attached there's a PR open for this issue
Milestone

Comments

@ibaryshnikov
Copy link
Member

🐛 Bug description

In help message target still defaults to browser

More details:
wasm-pack build --help prints this:

-t, --target <target>        Sets the target environment. [possible values: browser, nodejs, web, no-modules]
                                 [default: browser]

In the book the default is bundler

Actually, both are supported, but --target browser silently became deprecated
https://github.com/rustwasm/wasm-pack/blob/master/src/command/build.rs#L97

🤔 Expected Behavior

wasm-pack build --help should print that bundler is the default target, and maybe include some information about deprecation of browser target

🌍 Your environment

wasm-pack version: 0.8.1

I'd like to submit a pr if this update makes sense

@ashleygwilliams
Copy link
Member

ah ha! i did Not Realize that that had changed in wasm-bindgen. thank you so much for filing an issue. i'd love a PR for this and it would be great to also update the documentation!

cc @alexcrichton is this assessment correct? is there anything else that we may have missed that updated in wasm-bindgen? @ibaryshnikov please go ahead an open up a PR and we can discuss anything else there!

@ashleygwilliams ashleygwilliams added the bug Something isn't working label Apr 29, 2019
@alexcrichton
Copy link
Contributor

Oh I think this is just outdated documentation, AFAIK the default is "bundler" in both wasm-bindgen and wasm-pack

@ashleygwilliams
Copy link
Member

closed by #640 by way of #678

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working current release current todo items PR attached there's a PR open for this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants