Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for wasm-bindgen --weak-refs flag #930

Closed
mmgeorge opened this issue Oct 27, 2020 · 1 comment · Fixed by #937
Closed

Add support for wasm-bindgen --weak-refs flag #930

mmgeorge opened this issue Oct 27, 2020 · 1 comment · Fixed by #937
Labels
feature request PR attached there's a PR open for this issue

Comments

@mmgeorge
Copy link

💡 Feature description

The wasm-bindgen --weak-refs flag adds support for using TC39 Weak References proposal to garbage collect rust objects avoiding the need to explicitly call free. Currently this is supported on major browsers with the exception of Safari.

It would be great if we could pass this down to wasm-bindgen using wasm-pack.
@serprex serprex mentioned this issue Nov 19, 2020
Merged
@ashleygwilliams ashleygwilliams added PR attached there's a PR open for this issue feature request labels Dec 21, 2020
@jeremyBanks jeremyBanks mentioned this issue Jul 2, 2021
Closed
@bes
Copy link

bes commented Dec 22, 2021 •
edited
Loading

Safari 14.1 added support for weak refs. Safari 14.1 was released April 26, 2021.

This feature would be very appreciated 👍

Edit: Supported on iOS Safari from 14.5

@ctm ctm mentioned this issue Jan 6, 2022
Closed
@cycraig cycraig mentioned this issue Mar 7, 2022
Merged
10 tasks
@ept ept mentioned this issue May 25, 2022
Closed
@TimothyOlsson TimothyOlsson mentioned this issue Jun 22, 2022
Closed
@Sayan751 Sayan751 mentioned this issue Oct 10, 2022
Open
@PhilippGackstatter PhilippGackstatter mentioned this issue Nov 28, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request PR attached there's a PR open for this issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pass through --weak-refs --reference-types flags to bindgen serprex/wasm-pack
3 participants
@bes @ashleygwilliams @mmgeorge