{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":514142944,"defaultBranch":"main","name":"knative-rs","ownerLogin":"rusty-jules","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2022-07-15T05:16:27.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/39018167?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1707729523.0","currentOid":""},"activityList":{"items":[{"before":"f345af00b3f14776f43b39d81a568fd400e8f9f9","after":"d666f7f669ced7f045d1f5bdb3c7495133609348","ref":"refs/heads/main","pushedAt":"2024-02-12T10:04:17.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"rusty-jules","name":"Julian Aichholz","path":"/rusty-jules","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/39018167?s=80&v=4"},"commit":{"message":"Get referenced obj using dynamic GVK API Rebased (#9)\n\n* Get referenced obj using dynamic GVK API\r\n\r\nSigned-off-by: Nitish Malhotra <nitish.malhotra@gmail.com>\r\n\r\n* use normal Error\r\n\r\n* feat: implement AddressableType\r\n\r\nfix: rebase master\r\n\r\n* feat: switch Url for Uri in Destination with custom Option serde impl\r\n\r\nThe spec allows for sink parameters to specify both a ref and a uri. In\r\nthat case, the uri must be a path that is set on the resolved ref url.\r\nOnly if no ref is specified must the uri be an absolute url.\r\n\r\nThis makes the url type too strict for this field since url must always\r\nbe absolute.\r\n\r\n* fix: handle kref group contained in apiVersion\r\n\r\n* feat: custom schema for uri to handle nullable\r\n\r\n* fix: wrong field name for AddressableStatus\r\n\r\n* feat: addressable_type tests with mock k8s config and objects\r\n\r\n* refactor: remove DiscoveryError, keeping only top-level Error\r\n\r\nSome small clippy lint fixes as well\r\n\r\n* refactor: Addressable url no longer Cow\r\n\r\n* refactor: make AddressableTypeExt trait for transformations\r\n\r\n* refactor: lowercase addressableerr strings\r\n\r\n* feat: build_service_url\r\n\r\nUse a shared fn build_service_url for both DynamicObject and Service\r\ntypes when getting the url via AddressableTypeExt.\r\n\r\n* refactor: remove error variant, rename try_get_address -> address\r\n\r\n* fix: uri should extend kreference url, not overwrite a potential path\r\n\r\n* fix(knative): remove unused error\r\n\r\n---------\r\n\r\nSigned-off-by: Nitish Malhotra <nitish.malhotra@gmail.com>\r\nCo-authored-by: Nitish Malhotra <nitish.malhotra@gmail.com>","shortMessageHtmlLink":"Get referenced obj using dynamic GVK API Rebased (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2129709437\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rusty-jules/knative-rs/issues/9\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rusty-jules/knative-rs/pull/9/hovercard\" href=\"https://github.com/rusty-jules/knative-rs/pull/9\">#9</a>)"}},{"before":"f38b2da157f82620bdebdc33c86568b206c9b491","after":"f4925f84ff4631029cd95b9bc2aa261b99d7dd42","ref":"refs/heads/feat/kref-uri-resolver-impl-rebase","pushedAt":"2024-02-12T09:54:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"rusty-jules","name":"Julian Aichholz","path":"/rusty-jules","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/39018167?s=80&v=4"},"commit":{"message":"fix(knative): remove unused error","shortMessageHtmlLink":"fix(knative): remove unused error"}},{"before":null,"after":"f38b2da157f82620bdebdc33c86568b206c9b491","ref":"refs/heads/feat/kref-uri-resolver-impl-rebase","pushedAt":"2024-02-12T09:18:43.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"rusty-jules","name":"Julian Aichholz","path":"/rusty-jules","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/39018167?s=80&v=4"},"commit":{"message":"fix: uri should extend kreference url, not overwrite a potential path","shortMessageHtmlLink":"fix: uri should extend kreference url, not overwrite a potential path"}},{"before":"2246365e8a9c00834db9937213bbdeec224d8cac","after":null,"ref":"refs/heads/feat/kref-uri-resolver-impl-rebase","pushedAt":"2024-02-12T09:18:21.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"rusty-jules","name":"Julian Aichholz","path":"/rusty-jules","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/39018167?s=80&v=4"}},{"before":"2246365e8a9c00834db9937213bbdeec224d8cac","after":null,"ref":"refs/heads/kref-uri-resolver-impl-prerebase","pushedAt":"2024-02-12T09:18:02.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"rusty-jules","name":"Julian Aichholz","path":"/rusty-jules","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/39018167?s=80&v=4"}},{"before":null,"after":"2246365e8a9c00834db9937213bbdeec224d8cac","ref":"refs/heads/kref-uri-resolver-impl-prerebase","pushedAt":"2024-02-12T09:17:37.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"rusty-jules","name":"Julian Aichholz","path":"/rusty-jules","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/39018167?s=80&v=4"},"commit":{"message":"fix: uri should extend kreference url, not overwrite a potential path","shortMessageHtmlLink":"fix: uri should extend kreference url, not overwrite a potential path"}},{"before":"8a4f0ee65500d88782719ea8178c551756f72800","after":"f345af00b3f14776f43b39d81a568fd400e8f9f9","ref":"refs/heads/main","pushedAt":"2024-02-12T09:12:18.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"rusty-jules","name":"Julian Aichholz","path":"/rusty-jules","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/39018167?s=80&v=4"},"commit":{"message":"Use Enumset for ConditionType Dependents (#6)\n\n* feat: use EnumSetType instead of &'static [Self] for CondtionType deps\r\n\r\nThis change brings two benefits at the cost of an additional dependency:\r\n\r\n1. Avoiding String allocations and hashing in the assert on unique\r\nConditionTypes in Conditions::with_conditions\r\n2. Enforcing that dependents returned by ConditionType::dependents is a\r\nset\r\n\r\nEnumSetType also derives Clone, Copy, and PartialEq automatically.\r\n\r\n* feat: cleaner set assertion on Conditions\r\n\r\n* cleanup: simpler check for mark_unknown\r\n\r\n* cleanup: remove the 'static bound on ConditionType\r\n\r\n* chore: fix status_types test due to rebase\r\n\r\n* feat: re-export EnumSetType from knative::derive\r\n\r\nThis should make it easier for users to derive EnumSetType\r\nwithout needing to add it to their Cargo.toml since it is\r\nrequired by the crate anyways.","shortMessageHtmlLink":"Use Enumset for ConditionType Dependents (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1333683360\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rusty-jules/knative-rs/issues/6\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rusty-jules/knative-rs/pull/6/hovercard\" href=\"https://github.com/rusty-jules/knative-rs/pull/6\">#6</a>)"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAD-EeFYAA","startCursor":null,"endCursor":null}},"title":"Activity · rusty-jules/knative-rs"}