We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fetchHost
I'm wondering about the decision of not following redirects with http.Client within fetchHost function: https://github.com/rverton/webanalyze/blob/master/webanalyze.go#L105
http.Client
Following HTTP redirects is crucial for our use case.
What do you think about adding the ability to provide some custom http.Client to NewWebAnalyzer?
NewWebAnalyzer
I'm going to submit a pull request to better describe the idea.
The text was updated successfully, but these errors were encountered:
Hi @pshevtsov, following redirects often led to leaving the target scope/environment.
I'm open to make this more configurable if you need it.
Greetings
Sorry, something went wrong.
@rverton PTAL #37
No branches or pull requests
I'm wondering about the decision of not following redirects with
http.Client
withinfetchHost
function: https://github.com/rverton/webanalyze/blob/master/webanalyze.go#L105Following HTTP redirects is crucial for our use case.
What do you think about adding the ability to provide some custom
http.Client
toNewWebAnalyzer
?I'm going to submit a pull request to better describe the idea.
The text was updated successfully, but these errors were encountered: