Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetchHost doesn't follow redirects #35

Closed
przmv opened this issue Sep 4, 2020 · 2 comments
Closed

fetchHost doesn't follow redirects #35

przmv opened this issue Sep 4, 2020 · 2 comments

Comments

@przmv
Copy link
Contributor

przmv commented Sep 4, 2020

I'm wondering about the decision of not following redirects with http.Client within fetchHost function: https://github.com/rverton/webanalyze/blob/master/webanalyze.go#L105

Following HTTP redirects is crucial for our use case.

What do you think about adding the ability to provide some custom http.Client to NewWebAnalyzer?

I'm going to submit a pull request to better describe the idea.

@rverton
Copy link
Owner

rverton commented Sep 4, 2020

Hi @pshevtsov,
following redirects often led to leaving the target scope/environment.

I'm open to make this more configurable if you need it.

Greetings

@przmv
Copy link
Contributor Author

przmv commented Sep 4, 2020

@rverton PTAL #37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants