-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github Actions: Fix coverage task #1815
Comments
There are a couple of things I'm noticing. First, when running @scottgonzalez Do you recall why that change was made? I'm sure it was purposeful, but it seems to cause a problem. Next, when running |
Regarding the first issue, the first firing of i2cReadOnce comes from sip. The others are coming from the proximity.js SRF-10 read callback (line 100). |
I made the change because the test was failing and the check for exactly 1 would mean that the failure of too many calls would keep the interval around. The change causes the test to properly fail on the call count assertion a few lines later rather than leaving the interval running forever. |
That totally makes sense, and thanks for the quick reply. I'll see if I can figure out a good way to distinguish calls to i2cReadOnce between sip and proximity. |
No description provided.
The text was updated successfully, but these errors were encountered: