-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(async) Use the futures 0.3 - compatible versions of hyper and tokio #1071
Comments
I've made a proof of concept / WIP: https://github.com/SergioBenitez/Rocket/compare/async...jebrosen:async-futures03-hyper?expand=1 This makes use of https://github.com/Nemo157/futures-tokio-compat because tokio's |
Tokio's 0.2 alpha has been released, which includes support for |
Unfortunately hyper is completely broken for a few days due to some changes in tokio. It will maybe be fixed by hyperium/hyper#1890. |
I have updated the async branch to use As the commit message explains, tokio-rs/tokio#1356 causes some tests to fail. My own other mistake is also causing some of the same tests to fail, and I would like to wait for the upstream tokio issue to be resolved before trying too hard to fix those. |
hyper 0.13 and tokio 0.2 are slated to use futures 0.3. We should use those, ideally by the first release of async-capable Rocket. This would allow us to remove our own dependencies on the futures 0.1 ecosystem and the futures 0.1-0.3 compatibility layer.
The following issues make that inconvenient today:
We needUsing a different approach.hyper::body::Sender
to implement the newSink
trait, or find a different approach for that section of code.The text was updated successfully, but these errors were encountered: