Ensure csp-headers command emits to standard out (to allow for piping into other programs)
#107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exelord
force-pushed
the
fix-csp-command
branch
from
fff6f0e to
a0a605a
Compare
|
This moves the output from |
Ya, agree. Though I think we are already queuing master up to be a breaking change release (due to things like Node version support changes), right? |
rwjblue
approved these changes
Aug 9, 2019
rwjblue
changed the title
csp-headers command emits to standard out (to allow for piping into other programs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this.ui.writeLineis automatically covering the--silentoption. There is no need to wrap it up with the if.The result should be always logged even in silent mode. There is no point to run this command without returning a header payload. That's why I used
console.logas it logs always. Also, this will allow for saving the result to file eg:ember csp-headers --silent > csp.txtwhich can be later used during the deploy etc...