inject runtime config only if FastBoot dependency exists #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
reviewed
Dec 20, 2019
Co-Authored-By: Robert Jackson <me@rwjblue.com>
rwjblue
approved these changes
Dec 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that runtime configuration is not injected if it's not needed cause consuming app does not have a dependency on FastBoot.
Have verified manually that it's working by using this feature branch in a new app.
ember-cli-version-checkerseems to report wrong information if used withyarn linkandember-cli-content-security-policy, which makes testing this one difficult and may cause confusion. Symlinking the addon may be causing the issue in both cases. Need to investigate a little bit more and report their.It also sounds similar to ember-cli/ember-cli-version-checker#93. There the issue was traced down that some dependencies was causing an old version of ember-cli-version-checker to be used. Need to investigate if that one cause the issues here as well. But will do separately. Please feel free to merge this one with the skipped test.
Closes #116