Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consistent test results regardless of environment #122

Conversation

jelhan
Copy link
Collaborator

@jelhan jelhan commented Dec 20, 2019

This ensures that CSP configured for test environment is always used regardless how the tests are executed (ember test, ember test --server, ember serve and opening http://localhost:4200/tests in a browser). It also removes some CSP only required for tests from the CSP meta tag in index.html if build includes tests and from CSP header used for serving index.html with ember serve.

Closes #119

@jelhan jelhan mentioned this pull request Dec 20, 2019
10 tasks
@rwjblue rwjblue merged commit f985629 into adopted-ember-addons:master Dec 20, 2019
@rwjblue
Copy link
Member

rwjblue commented Dec 20, 2019

Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure consistent test results by always using test environment for CSP affecting tests
2 participants