Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent unnecessary meta + reportOnly warning #134

Merged
merged 2 commits into from
Apr 8, 2020

Conversation

reidab
Copy link
Contributor

@reidab reidab commented Mar 19, 2020

This warning was being output on dev server startup when test-head was rendered, even if both of the settings mentioned in the message were set to avoid it.

This warning was being output when `test-head` was rendered, even if both of the settings mentioned in the message were set to avoid it.
Copy link
Collaborator

@jelhan jelhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for testing master, reporting bugs and even fixing them! Noticed that there are even more issues with that warning. Do you have time to work on it?

index.js Show resolved Hide resolved
@jelhan jelhan added the bug label Mar 20, 2020
@jelhan jelhan mentioned this pull request Apr 6, 2020
10 tasks
@jelhan
Copy link
Collaborator

jelhan commented Apr 8, 2020

@reidab Updated the warning text in 44edd97. Hope it was okay to push to your pull request.

@jelhan jelhan merged commit ef79966 into adopted-ember-addons:master Apr 8, 2020
@reidab
Copy link
Contributor Author

reidab commented Apr 14, 2020

@jelhan that's great! thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants