use environment from appConfig instead of deriving it ourselves #249
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems as if
appConfig.environment
istest
wheneverconfig
hook runs fortests/index.html
. I'm confused why we had that complex code to detect if the hook is run forindex.html
ortests/index.html
in the first place. Let's see if our CI pipeline tells us that this wasn't the case for older Ember CLI versions.Fixes #204