Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use environment from appConfig instead of deriving it ourselves #249

Merged
merged 2 commits into from
Oct 28, 2021

Conversation

jelhan
Copy link
Collaborator

@jelhan jelhan commented Oct 28, 2021

It seems as if appConfig.environment is test whenever config hook runs for tests/index.html. I'm confused why we had that complex code to detect if the hook is run for index.html or tests/index.html in the first place. Let's see if our CI pipeline tells us that this wasn't the case for older Ember CLI versions.

Fixes #204

@jelhan jelhan added the bug label Oct 28, 2021
@jelhan jelhan merged commit a53418f into master Oct 28, 2021
@delete-merged-branch delete-merged-branch bot deleted the support-storeConfigInMeta-false branch October 28, 2021 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build fails with storeConfigInMeta=false
1 participant