-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to output raw csp (fix #81) #84
Add option to output raw csp (fix #81) #84
Conversation
Did you considered In contrast to
|
@YoranBrondsema Looks good! However, I'm hesitant to merge due to the stderr -> stdout switch (3c8b3bb). While I think the change makes sense, maybe there is a reason for it that I don't know about. So I'd like to check with @rwjblue to see that there aren't a special reason for outputting to stderr. |
3c8b3bb
to
5c2bcca
Compare
@sandstrom is correct, emitting to stdout breaks things that attempt to parse the console output for test pass/fail. However, it may not be a factor in our case (e.g. if we only emit during development but not tests), right? @YoranBrondsema - I'm also curious what motivated that particular change? |
@rwjblue OK I understand the reasoning behind sending to stderr. The motivation to send to stdout is that
Either way, I realize now that this change does not belong in this PR. So I will undo it, so that this PR only adds the |
eba9a48
to
c515ca4
Compare
@YoranBrondsema I spoke with rwjblue about this. I interpreted his reasoning like this: For things that are consumed by tests, we cannot use stdout since it will mess with the pass/fail check. However, since this command won't be used during tests, it's fine to switch. So, in other words, feel free to open a new PR with the switch from stderr -> stdout. If you can, write a line or two about whether that would reasonably affect any tests and ping rwjblue in that PR. Happy to merge this PR! But could you look at the Travis issue first and see if you can fix that (perhaps just by forcing a rerun of the tests). |
c515ca4
to
1fc99a9
Compare
1fc99a9
to
6a139d1
Compare
@YoranBrondsema I don't know why one travis job fails, but I'm willing to merge anyway because I cannot see that anything changed in this PR could cause those errors. Thanks for your work on this! 🏅 |
I tried re-running it but it seems to consistently fail on the beta release of Ember.js. Thanks for the merge! |
--raw
option, the configuration guidelines are omitted.report-uri
option.