-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop node 4 and Ember CLI < 2.13 (update to Ember 3.7 blueprint) #87
Conversation
Since Ember 3.7 is available now, I've updated this PR accordingly. I also switched to Yarn per @jelhan's comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me! When we release, we'll need to make sure to mark this as a breaking change (dropping Node 4, support for ember-cli < 2.13, etc).
@loganrosen Is there anything else you'd like to do with this PR, before we merge? We'll make sure to add a changelog file where we can note that this is a breaking change. So that it'll be handled properly during the next version release. |
friendly ping @loganrosen |
@sandstrom Sorry for the delay! Just fixed a merge conflict against master (the Node version in |
@loganrosen Great, thanks! However, there seems to be a new error:
|
@sandstrom Fixed the Travis failure by setting |
@loganrosen Awesome, thanks!! 🙏🏻 |
Updating this addon to Ember 3.5, leveraging
ember-cli-update
.