Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop node 4 and Ember CLI < 2.13 (update to Ember 3.7 blueprint) #87

Merged
merged 3 commits into from
May 2, 2019
Merged

Conversation

loganrosen
Copy link
Contributor

Updating this addon to Ember 3.5, leveraging ember-cli-update.

@jelhan
Copy link
Collaborator

jelhan commented Feb 22, 2019

This looks good to me beside adding package-lock.json instead of yarn.lock. It would close #86 and #85.

@loganrosen loganrosen changed the title Update to Ember 3.5 Update to Ember 3.7 Feb 23, 2019
@loganrosen
Copy link
Contributor Author

Since Ember 3.7 is available now, I've updated this PR accordingly. I also switched to Yarn per @jelhan's comment.

@sandstrom sandstrom requested a review from rwjblue March 29, 2019 09:15
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me! When we release, we'll need to make sure to mark this as a breaking change (dropping Node 4, support for ember-cli < 2.13, etc).

@sandstrom
Copy link
Collaborator

@loganrosen Is there anything else you'd like to do with this PR, before we merge?

We'll make sure to add a changelog file where we can note that this is a breaking change. So that it'll be handled properly during the next version release.

@sandstrom
Copy link
Collaborator

friendly ping @loganrosen

@loganrosen
Copy link
Contributor Author

@sandstrom Sorry for the delay! Just fixed a merge conflict against master (the Node version in .travis.yml was bumped to 8 in #84). This should be good to merge now, once Travis passes.

@sandstrom
Copy link
Collaborator

@loganrosen Great, thanks!

However, there seems to be a new error:

Could not require 'ember-cli-build.js': Cannot find module 'broccoli-caching-writer'

@loganrosen
Copy link
Contributor Author

@sandstrom Fixed the Travis failure by setting useYarn to true in the ember-try configuration. This time I made sure it passed. 😄 Good to merge now.

@sandstrom sandstrom merged commit a2ac257 into adopted-ember-addons:master May 2, 2019
@sandstrom
Copy link
Collaborator

@loganrosen Awesome, thanks!! 🙏🏻

This was referenced Jun 24, 2019
@rwjblue rwjblue changed the title Update to Ember 3.7 Update to Ember 3.7 blueprint Jul 25, 2019
@jelhan jelhan mentioned this pull request Aug 13, 2019
10 tasks
@jelhan jelhan changed the title Update to Ember 3.7 blueprint Drop node 4 and Ember CLI < 2.13 (update to Ember 3.7 blueprint) Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants