You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Without it there could be a situation when one developer runs npm install --save-dev ember-cli-rails-addon and commits changes to package.json, but then other developer pulls the change and runs rails without running npm install.
NPM doesn't actually perform any dependency checking before executing the code, so builds are running without the addon, and all sorts of weird shit happening. :(
The text was updated successfully, but these errors were encountered:
The problem is the gem only checks package.json, but not the actual presence of stuff in node_modules. We had an issue when package.json check passed successfully and builds were happening, but the addon was not installed and loaded.
So, when addon is not running, adding checks to it won't solve the problem.
I think the other thing we could/should do is to make addon check smarter and actually make it go deeper into node-modules to eliminate these situations.
Without it there could be a situation when one developer runs
npm install --save-dev ember-cli-rails-addon
and commits changes topackage.json
, but then other developer pulls the change and runs rails without runningnpm install
.NPM doesn't actually perform any dependency checking before executing the code, so builds are running without the addon, and all sorts of weird shit happening. :(
The text was updated successfully, but these errors were encountered: