Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nerdtree: no icons on newly created files #153

Closed
7 of 8 tasks
dflupu opened this issue May 18, 2016 · 12 comments
Closed
7 of 8 tasks

nerdtree: no icons on newly created files #153

dflupu opened this issue May 18, 2016 · 12 comments
Assignees
Milestone

Comments

@dflupu
Copy link

dflupu commented May 18, 2016

Same as issue #33 which is closed.
I'm using the latest versions of nerdtree and vim-devicons.

Requirements

If you are not sure whether or not what you are reporting is actually an issue or you have a general question please message in the Gitter Chat Room

These items you acknowledge and mark off with 'x' please

  • I have searched the issues for my issue and found nothing related and/or helpful
  • I have read or at least glanced at the FAQ
  • I have read or at least glanced at the Wiki

These items you must provide answers to. Make sure to add all the information needed to understand the bug so that someone can help. If the info is missing we'll add the 'Needs more information' label and may choose to close the issue until there is enough information.

  • What version of vim are you using?
    • hint: vim --version

NVIM v0.1.4-5-g5330aa1
and
VIM - Vi IMproved 7.4 (2013 Aug 10, compiled Apr 8 2016 14:36:27)
Included patches: 1-1718

  • What version of vim-devicons are you using?

    • hint: :echo webdevicons#version()

    0.8.2

  • Are you using vim from the terminal or a GUI vim? terminal

  • Are you using Mac, Linux or Windows? linux

Optional

  • Provide screenshots where appropriate
@ryanoasis
Copy link
Owner

Thanks ill try to replicate today

@ryanoasis
Copy link
Owner

So far I am unable to replicate so far though I have not tried the exact setup you have.

Do you have a link to your vimrc you are using so I can test if there is anything specific in it?

@dflupu
Copy link
Author

dflupu commented May 24, 2016

I would have a hard time sharing my vimrc, since it's split into multiple files.
I went ahead and tested with a vimrc containing only the following

call plug#begin()
Plug 'scrooloose/nerdtree'
Plug 'ryanoasis/vim-devicons'
call plug#end()

and the issue did not go away. Autoload directory only contains vim-plug. Also tested with pathogen.

@ryanoasis
Copy link
Owner

@dflupu Ah okay thanks, I'll try again

@ryanoasis
Copy link
Owner

can you tell me what you get for the output of echo g:NERDTreeUpdateOnCursorHold ?

@dflupu
Copy link
Author

dflupu commented May 27, 2016

E121: Undefined variable: g:NERDTreeUpdateOnCursorHold
E15: Invalid expression: g:NERDTreeUpdateOnCursorHold

@ryanoasis
Copy link
Owner

Hey thanks for testing that. Looks like you found a bug (oversight on my part).

See I use nerdtree-git-plugin and I stole/borrowed a fix idea from there for refreshing the nerdtree flags but looks like I forgot to even set that variable!

See my commit on the initial attempt at a fix: 710f3b2

But I need to do something (as shown here: https://github.com/Xuyuanp/nerdtree-git-plugin/blob/e71e62fb5ca3e49035a7f2a85c81e5b85b1cf138/nerdtree_plugin/git_status.vim#L37-L39) for setting that variable 😊

So basically I could not replicate your issue until I removed the nerdtree-git-plugin plugin and now I get the same error as you.

@ryanoasis
Copy link
Owner

The fix is up on 0.8.3 branch if you would like to test it out.

I won't be able to do any changes until Tuesday

@dflupu
Copy link
Author

dflupu commented May 31, 2016

I've tested it a bit. It does work, but it takes some time until the icon appears after a file is created. Seconds, even. Is it based on some kind of timeout ?

@ryanoasis
Copy link
Owner

ryanoasis commented Jun 1, 2016

@dflupu Yeah basically it is as far as I understand. I will see if I can try to improve the speed a bit.

Try to see what you have set for updatetime

For me I have it set to 250 for gitgutter in my vimrc so that is why I probably see the icon show up fairly quickly, without it the default seems to be 2 seconds (2000).

@dflupu
Copy link
Author

dflupu commented Jun 1, 2016

That pretty much solved it. Thanks !
The default updatetime in my version of vim was actually 4 seconds.

@ryanoasis
Copy link
Owner

Great! No problem 😄

I will try to add this info to the readme for the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants