Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folder titles off by a single space after opening #197

Closed
ismay opened this issue Feb 24, 2017 · 8 comments
Closed

Folder titles off by a single space after opening #197

ismay opened this issue Feb 24, 2017 · 8 comments
Assignees
Milestone

Comments

@ismay
Copy link

ismay commented Feb 24, 2017

Sorry for spamming you with issues, but I couldn't find this in the faq or other issues. With the following settings:

  let g:WebDevIconsUnicodeDecorateFolderNodes = 1
  let g:DevIconsEnableFoldersOpenClose = 1

When opening a folder, the titles of the opened folder move to the left a single space (scripts and tmux folders):

image

I'm assuming that's a bug? My setup is the same as in the previous issue, I can copy it over if you'd like. Let me know if you need more info.

@ryanoasis
Copy link
Owner

Sorry for spamming you with issues

No worries! 😄

Interesting issue. This is enough info for now I will try to replicate this weekend 😅

@ryanoasis
Copy link
Owner

I think I have found the issue. We can target this for the next release. Thanks again 😄

@ryanoasis ryanoasis added this to the v0.9.0 milestone Apr 6, 2017
@ryanoasis ryanoasis self-assigned this Apr 6, 2017
@ismay
Copy link
Author

ismay commented Apr 6, 2017

Cool np, looking forward to it! 👍

@XadillaX
Copy link

XadillaX commented May 27, 2017

This PR and issue hurt me.

before:

after:

@ryanoasis
Copy link
Owner

@XadillaX Ouchie! 😊 😢 sorry about that...

Can you tell us your vimrc settings for vimdevicons, or are you using all default settings?

@vysnet
Copy link

vysnet commented Jul 12, 2017

Hey @ryanoasis,
I have the same problem as @XadillaX - this patch causes a regression for me. Just updated vim-devicons from v0.8.6 to the latest v0.9.2

Before the patch:
vim-devicons-before

After the patch:
vim-devicons-after

I am using the following version of gvim:

VIM - Vi IMproved 7.4 (2013 Aug 10, compiled Nov 24 2016 16:44:48)
Included patches: 1-1689
Extra patches: 8.0.0056

Custom settings applied for devicons:

let g:webdevicons_enable_nerdtree = 1
let g:WebDevIconsUnicodeDecorateFolderNodes = 1
let g:WebDevIconsNerdTreeAfterGlyphPadding = ''
let g:WebDevIconsNerdTreeGitPluginForceVAlign = 1
let g:DevIconsEnableFoldersOpenClose = 1
let g:DevIconsEnableFolderExtensionPatternMatching = 1

I traced down the problem to the following line: https://github.com/ryanoasis/vim-devicons/blob/master/plugin/webdevicons.vim#L748 on the latest version.
Is there any particular reason why the function is called with a disabled artifact fix?
When the flag is enabled the plugin applies the correct paddings/fixes as expected.

@ryanoasis Let me know if I should submit the pull request with the fix.

@ryanoasis
Copy link
Owner

Really sorry about the delays people. Hopefully we can straighten things out next release 🤞

@ryanoasis
Copy link
Owner

Plan of action here: #225 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants