-
-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add error codes 2103 & 2105 #789
Comments
Feel free to create a PR to add those, but could you also check what does it say for the state when this happens? It feels a bit odd that errors are being reported when everything is actually fine.. :-) |
You are so right, but the whole thing is a little odd. ;-) |
1st output with eror 2105. Already modified my viomivacuum.py State: ViomiVacuumState.Docked |
output with error 2103 charging. Already modified my viomivacuum.py State: ViomiVacuumState.Docked |
Ah, I see. I think they're simply using the error field to indicate also non-error statuses. So I think the question here is, maybe those "non-erroneous" states should be exposed as the state (so instead of At some point, it would be great to have a common API for all supported vacuums no matter whether it is from rockrobo, viomi or dreame, just to consolidate the API and make it more accessible for downstreams like homeassistant. |
Please close the issue. |
Made a pull request with the error and other messages I found. |
When the vacuum bot is charging it seems to use error 2103
When the vacuum bot is fully charged it seems to use error 2105.
Lets add the error message definition and check if other have the same observation.
python-miio/miio/viomivacuum.py
Line 41 in 30752c3
2103: "Charging",
2105: "Fully charged",
Model: Xiaomi Mi Robot Vacuum-Mop P
Hardware version: STYTJ02YM
Firmware version: 3.5.3_0017
The text was updated successfully, but these errors were encountered: