Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add error codes 2103 & 2105 #789

Closed
fs79 opened this issue Aug 4, 2020 · 7 comments
Closed

add error codes 2103 & 2105 #789

fs79 opened this issue Aug 4, 2020 · 7 comments

Comments

@fs79
Copy link
Contributor

fs79 commented Aug 4, 2020

When the vacuum bot is charging it seems to use error 2103
When the vacuum bot is fully charged it seems to use error 2105.

Lets add the error message definition and check if other have the same observation.


2103: "Charging",
2105: "Fully charged",

Model: Xiaomi Mi Robot Vacuum-Mop P
Hardware version: STYTJ02YM
Firmware version: 3.5.3_0017

@rytilahti
Copy link
Owner

Feel free to create a PR to add those, but could you also check what does it say for the state when this happens? It feels a bit odd that errors are being reported when everything is actually fine.. :-)

@fs79
Copy link
Contributor Author

fs79 commented Aug 5, 2020

You are so right, but the whole thing is a little odd. ;-)
I´´ll update this trhtread with status output when its charging and when its fully charged.
Perhaps I´m overlooking something.

@fs79
Copy link
Contributor Author

fs79 commented Aug 5, 2020

1st output with eror 2105. Already modified my viomivacuum.py

State: ViomiVacuumState.Docked
Mode: ViomiMode.Vacuum
Error: Fully charged (2105)
Battery: 100
Fan speed: ViomiVacuumSpeed.Silent
Box type: ViomiBinType.Vacuum
Mop type: 0
Clean time: 0:00:02
Clean area: 2.35
Water grade: ViomiWaterGrade.High
Remember map: True
Has map: True
Has new map: False
Mop mode: ViomiMode.Vacuum

@fs79
Copy link
Contributor Author

fs79 commented Aug 6, 2020

output with error 2103 charging. Already modified my viomivacuum.py

State: ViomiVacuumState.Docked
Mode: ViomiMode.Vacuum
Error: Charging (2103)
Battery: 68
Fan speed: ViomiVacuumSpeed.Silent
Box type: ViomiBinType.Vacuum
Mop type: 0
Clean time: 0:00:49
Clean area: 41.86
Water grade: ViomiWaterGrade.High
Remember map: True
Has map: True
Has new map: False
Mop mode: ViomiMode.Vacuum

@rytilahti
Copy link
Owner

Ah, I see. I think they're simply using the error field to indicate also non-error statuses. So I think the question here is, maybe those "non-erroneous" states should be exposed as the state (so instead of Docked it would show Charging when it's still charging, and so on).

At some point, it would be great to have a common API for all supported vacuums no matter whether it is from rockrobo, viomi or dreame, just to consolidate the API and make it more accessible for downstreams like homeassistant.

@fs79
Copy link
Contributor Author

fs79 commented Aug 15, 2020

Please close the issue.
Made a pull request with the error and other messages I found.

@fs79
Copy link
Contributor Author

fs79 commented Aug 15, 2020

Made a pull request with the error and other messages I found.

@fs79 fs79 closed this as completed Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants