Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language selection only works on right-hand side of diff #14

Closed
joeskeen opened this issue Sep 14, 2017 · 3 comments
Closed

Language selection only works on right-hand side of diff #14

joeskeen opened this issue Sep 14, 2017 · 3 comments

Comments

@joeskeen
Copy link

When comparing larger chunks of text, it's nice to be able to set the language to get syntax highlighting. When comparing files, VSCode does this for us automatically (based on the file type). When setting the language in a partial diff, however, it only sets the language for the right-hand side, leaving the left-hand side as 'plain text'.

image

@joeskeen
Copy link
Author

joeskeen commented Sep 14, 2017

It looks like this is a vscode bug (as I tested it with plaintext files in VSCode), so I'm going to post a bug there.
Update: reported as microsoft/vscode#34408

@ryu1kn
Copy link
Owner

ryu1kn commented Sep 16, 2017

Thanks for also checking the editor behaviour.

I thought partial diff doesn't set the language for neither sides as I'm not sure if vscode can do syntax highlighting correctly if they have only part of text present in the diff view.

@joeskeen
Copy link
Author

microsoft/vscode#34408 has been fixed, which fixes this issue! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants