Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmetic improvements #15

Merged
merged 3 commits into from
May 12, 2018
Merged

Cosmetic improvements #15

merged 3 commits into from
May 12, 2018

Conversation

Kronuz
Copy link
Contributor

@Kronuz Kronuz commented Apr 28, 2018

  • Better foreground color contrast (calculated)
  • Rounded selection

@ryu1kn
Copy link
Owner

ryu1kn commented May 12, 2018

@Kronuz Apologies for my slow response and thank you for the PR!

It's great, the characters under highlights are much more visible now. I'm happy to merge this in but I'm thinking to introduce a flag to enable this feature as it overwrites the colour given by the syntax highlighting, and some people might want to see the original colour 😉

@ryu1kn ryu1kn merged commit 45d5efb into ryu1kn:master May 12, 2018
ryu1kn added a commit that referenced this pull request May 12, 2018
@Kronuz
Copy link
Contributor Author

Kronuz commented May 12, 2018

@ryu1kn I have since updated a couple other things and fixed a bug, I’ll add another pull request to fix that.

@ryu1kn
Copy link
Owner

ryu1kn commented May 13, 2018

Cool thanks @Kronuz 👍It hasn't been released yet, so take your time 😉

@ryu1kn
Copy link
Owner

ryu1kn commented May 15, 2018

Hi @Kronuz , I need to make a change on master; so I've created a branch highcontrast-text-colour that is equivalent to the master and rewound the master back to the state before merging your changes. You can create a PR against highcontrast-text-colour branch when it's ready. Thanks 😉

@Kronuz
Copy link
Contributor Author

Kronuz commented May 22, 2018

The bug was already fixed in the pull request, I just didn't think it was... the other thing I changed was using color-name package instead of declaring the color names ourselves. I'm opening a new pull request for that one now :)

@ryu1kn
Copy link
Owner

ryu1kn commented Jun 21, 2018

Sorry the slow response. I've just published it as v1.2.0! Thanks for your help 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants