Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Accept-Language in --create-template #180

Open
Dfte opened this issue Jul 5, 2021 · 0 comments
Open

Add Accept-Language in --create-template #180

Dfte opened this issue Jul 5, 2021 · 0 comments

Comments

@Dfte
Copy link

Dfte commented Jul 5, 2021

Hey,

So i have been working with the --create-template option. So first of all it is bugged as of now. I already mentioned the solution here #172 (comment)

The solution would be to install a mono thread version of pywebcopy that you can find here https://github.com/davidwgrossman/pywebcopy.

While using the cloner i realized that cloning some websites (for example twitter) without sending the language-accept HTTP header would result in pywebcopy to clone all pages for all languages and possibly different contents (images, css whatever) which would take a loooooooooooooooooong time.

Thus i think it would be a good idea to add an option that would allow us to pass custom headers ie : --headers "Accept-Language: fr" to retrieve only the french version of the website.

I post this issue as a feature request but I'll take care of it and PR as soon as possible :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants