Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Vercel Analytics #131

Open
PaulRBerg opened this issue Feb 1, 2024 · 8 comments
Open

Enable Vercel Analytics #131

PaulRBerg opened this issue Feb 1, 2024 · 8 comments
Assignees
Labels
effort: medium Default level of effort. priority: 2 We will do our best to deal with this. type: feature New feature or request. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise.

Comments

@PaulRBerg
Copy link
Member

SCR-20240201-smem
@PaulRBerg PaulRBerg added priority: 2 We will do our best to deal with this. effort: medium Default level of effort. type: feature New feature or request. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise. labels Feb 1, 2024
@PaulRBerg
Copy link
Member Author

We would have to implement a cookie banner to enable these analytics, wouldn't we, @razgraf, @gavriliumircea?

@gavriliumircea
Copy link
Contributor

Yus but we should use the cookie banner that we already have

@PaulRBerg
Copy link
Member Author

PaulRBerg commented Feb 6, 2024

Got it. Would it be difficult to port that over to this repository?

Related: https://github.com/sablier-labs/v2-interfaces/discussions/454

@gavriliumircea
Copy link
Contributor

First of all we don't actually have a roadmap for the sdk. Further more we will be able to put there the component itself but the entire cookies system is a different discussion, we have a store related to those, config function, project keys so the complexity is increasing exponentially.

@PaulRBerg
Copy link
Member Author

First of all we don't actually have a roadmap for the sdk

I know. When I add related links, I just put it there for historical association reasons - not to push it as a high-priority item today.

Further more we will be able to put there the component itself but the entire cookies system is a different discussion

Surely we can have a minimal component just for the Vercel analytics and Crisp? We don't need Sentry and Mixpanel and the other stuff in the docs.


Maybe Docusaurus has a pre-fab solution for cookies? More research needed.

@gavriliumircea
Copy link
Contributor

We should discuss this in the call we have next week.

@razgraf
Copy link
Member

razgraf commented Feb 6, 2024

Worth noting that the SDK isn't very related to this discussion. The SDK would include Sablier branded elements (UI or flows) for integrators to use.

The "legal" components like any other very opinionated functionalities (like the cookie banner) would most likely not live in an SDK. Maybe in a shared internal components package (but we have that for now in the interfaces monorepo).


Looks like Vercel Analytics should be valid for an integration with Docusaurus. There's still the question of what the best approach is e.g., injecting the Analytics RC and handling beforeSend like in the app vs. using the plugin vs. other

Related links:

@PaulRBerg
Copy link
Member Author

Worth noting that the SDK isn't very related to this discussion.
...
The "legal" components like any other very opinionated functionalities (like the cookie banner) would most likely not live in an SDK

You're right.

Looks like Vercel Analytics should be valid for an integration with Docusaurus

Nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: medium Default level of effort. priority: 2 We will do our best to deal with this. type: feature New feature or request. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise.
Projects
None yet
Development

No branches or pull requests

3 participants