Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input JSON file for test ranges + weekly CI workflow #272

Open
PaulRBerg opened this issue Sep 27, 2024 · 1 comment
Open

Input JSON file for test ranges + weekly CI workflow #272

PaulRBerg opened this issue Sep 27, 2024 · 1 comment
Labels
effort: high Large or difficult task. priority: 2 We will do our best to deal with this. type: test Adding, updating, or removing tests. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.

Comments

@PaulRBerg
Copy link
Member

After #263 gets merged, let's add an input JSON file for defining test ranges, and modify the relevant tests like so:

  1. If the JSON file is not present, apply the default ranges, i.e., the realistic ones that stream ~$100 per month.
  2. Otherwise, load the ranges from the JSON file.

Then, add a new CI workflow that is scheduled to run on a weekly basis, which creates a JSON file with unrealistic test ranges.

This approach achieves the best of both worlds — focusing on realistic scenarios for the most part, but also proving that the protocol doesn't break when the payment rates are extreme.

@PaulRBerg PaulRBerg added effort: high Large or difficult task. priority: 1 This is important. It should be dealt with shortly. work: clear Sense-categorize-respond. The relationship between cause and effect is clear. type: test Adding, updating, or removing tests. labels Sep 27, 2024
@smol-ninja
Copy link
Member

A relevant discussion: #296 (comment)

@smol-ninja smol-ninja added priority: 2 We will do our best to deal with this. and removed priority: 1 This is important. It should be dealt with shortly. labels Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: high Large or difficult task. priority: 2 We will do our best to deal with this. type: test Adding, updating, or removing tests. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.
Projects
None yet
Development

No branches or pull requests

3 participants