Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store snapshot debt as a 18 decimal value #302

Closed
smol-ninja opened this issue Oct 13, 2024 · 0 comments · Fixed by #312
Closed

Store snapshot debt as a 18 decimal value #302

smol-ninja opened this issue Oct 13, 2024 · 0 comments · Fixed by #312
Assignees
@andreivladbrg
Labels
effort: medium Default level of effort. priority: 0 Do this first before everything else. This is critical and nothing works without this. type: perf Change that improves performance. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.

Comments

@smol-ninja
Copy link
Member

smol-ninja commented Oct 13, 2024 •
edited
Loading

As per cantina finding 11, storing snapshot debt as a 18 decimal value can increase precision.

Note: use uint256 for snapshotDebt as per #297 (reply in thread).
@smol-ninja smol-ninja added priority: 0 Do this first before everything else. This is critical and nothing works without this. type: perf Change that improves performance. effort: medium Default level of effort. work: clear Sense-categorize-respond. The relationship between cause and effect is clear. labels Oct 13, 2024
@andreivladbrg andreivladbrg mentioned this issue Oct 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreivladbrg andreivladbrg

Labels
effort: medium Default level of effort. priority: 0 Do this first before everything else. This is critical and nothing works without this. type: perf Change that improves performance. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: sd as 18 decimals sablier-labs/flow
2 participants
@smol-ninja @andreivladbrg