Allow for custom iTipBroker (#1559) [4.6]

[phil-davis]

Backport #1559 to 4.6

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.33%. Comparing base (fe09b0b) to head (dab90d5).
Report is 3 commits behind head on 4.6.

Additional details and impacted files

@@            Coverage Diff            @@
##                4.6    #1568   +/-   ##
=========================================
  Coverage     97.33%   97.33%           
- Complexity     2843     2844    +1     
=========================================
  Files           175      175           
  Lines          9441     9443    +2     
=========================================
+ Hits           9189     9191    +2     
  Misses          252      252           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kesselb]

Hi @phil-davis,

I was wondering with @SebastianKrupinski if you want to do a release for 4.6 with the patch? ;)

[phil-davis]

I was wondering with @SebastianKrupinski if you want to do a release for 4.6 with the patch?

This code ended up being released in https://github.com/sabre-io/dav/releases/tag/4.7.0 because it is an extra "feature" (along with other things in 4.7.0 that could be considered "features" rather than bug fixes.)

@kesselb 4.7.0 still supports all PHP 7.1 through 8.4. Is there any reason that you can't use 4.7.0 ?

[SebastianKrupinski]

Hi @phil-davis,

The patch allows us to fix some bugs in NC, and our supported stable releases use 4.6, so a updated 4.6 release would allow us to fix the issues, without having to custom patch those stable releases.

Thank you

[phil-davis]

@SebastianKrupinski the change is a "new feature" (adds the createItipBroker method). New "overriding" code that makes use of this would not work with 4.6.0. So it would be strange to have 4.6.1 that has this "new feature". Someone writing code to use the 4.6 series would have to know the exact patch version 4.6.0 or 4.6.1 when writing code related to this "new feature".

4.7 is upwardly compatible - any code that works with 4.6 should continue to work with 4.7

So I am not sure why the NC stable releases are somehow "pinned" to 4.6 - I would have thought they would be "pinned" to "4.6 or greater, within the 4.* series"