Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add additional checks around whether a SafeTransaction is cancelled or waiting to be indexed #392

Open
evitree opened this issue Nov 7, 2022 · 1 comment

Comments

@evitree
Copy link

evitree commented Nov 7, 2022

Discussed with @rmeissner offline

Add checks or work around for safe-app-sdk's getBySafeTxHash or Safe Transaction API's getTransaction endpoint to ensure that we have a way to tell whether a transaction was actually cancelled (invalidated nonce) or whether it is marked as cancelled temporarily (nonce transaction detected but transaction has not yet been indexed).

For now we have a work around to only accept cancelled transactions that have cleared a few minutes after it's last updated date.

@evitree
Copy link
Author

evitree commented Nov 7, 2022

related issue which was flagged: safe-global/safe-client-gateway#37

@mmv08 mmv08 changed the title add additional checks around whether a GnosisTransaction is cancelled or waiting to be indexed add additional checks around whether a SafeTransaction is cancelled or waiting to be indexed Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant