Improve ProxyFactory

[rmeissner]

Following changes should be made to the proxy factory:

• remove createProxy
  • This method uses create which is not counterfactual for a specific deployment. This cause user errors and potential lost/ stuck funds
• Add check that mastercopy exists
• If init data is provided it should be ensured that the mastercopy exists and that the init call was successful to avoid that a proxy is deployed uninitialized
• Add createNetworkSpecificProxy
  • This proxy will use the chainId in the salt and therefore it will not be possible to create it on the same address on other networks
  • This method should enable the creation of proxies that should really exist only on 1 network at the same address (e.g. specific governance or admin accounts)
• Remove calculateProxyAddress method because methods that use the revert approach to return data. It doesn't work well with all nodes (as they all return revert messages differently)

[mmv08]

btw @rmeissner what's our stance on ZkSync? Just raising this because our current proxy factory is not compatible with their compiler. I wonder if we should do something, perhaps, create a separate zk proof factory because I assume the problem we had with zksync is universal for all type 4 zkEVMs

For more context check matter-labs/hardhat-zksync#99

[rmeissner]

hmmm not sure if we require this method 🤔 Personally I am happy to remove it, iirc @Uxio0 added it in the past, so not sure if we use it somewhere.

[mmv08]

Looks like we have it in the safe-eth-py package but I don't see see it used on the backend

[Uxio0]

hmmm not sure if we require this method 🤔 Personally I am happy to remove it, iirc @Uxio0 added it in the past, so not sure if we use it somewhere.

We used it on the relay, as there was no way to get the deployment addresses for addresses that were not funded, as the deploy function reverted. We can remove it.