-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add overloaded checkNSignatures
#589
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshay-ap
changed the title
Try fitting checkNsigs in code size limit
Try fitting overloaded checkNsigs in code size limit
Jun 14, 2023
akshay-ap
force-pushed
the
test-checknsigs
branch
2 times, most recently
from
June 15, 2023 09:48
78d30b1
to
10eeeee
Compare
mmv08
force-pushed
the
release/v1.5.0
branch
3 times, most recently
from
July 3, 2023 12:21
1ba4f55
to
04403af
Compare
Can this be closed? |
yes |
mmv08
changed the title
Try fitting overloaded checkNsigs in code size limit
Add overloaded Jul 13, 2023
checkNSignatures
…into test-checknsigs
mmv08
requested review from
a team,
rmeissner,
Uxio0 and
mmv08
and removed request for
a team
July 18, 2023 09:00
mmv08
reviewed
Jul 18, 2023
…contracts into test-checknsigs
akshay-ap
commented
Aug 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mmv08
approved these changes
Aug 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Please pay attention to the test cases, we need to ensure that this thing is properly tested