From 48723676a959101a68c51471ef9a7c7dbcbc6df2 Mon Sep 17 00:00:00 2001 From: Uxio Fuentefria Date: Mon, 7 Feb 2022 15:28:06 +0100 Subject: [PATCH] Fix typing and defaults on SafeTx --- gnosis/safe/multi_send.py | 4 ++++ gnosis/safe/safe_tx.py | 10 +++++----- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/gnosis/safe/multi_send.py b/gnosis/safe/multi_send.py index 1ddc41abf..7828e1aa2 100644 --- a/gnosis/safe/multi_send.py +++ b/gnosis/safe/multi_send.py @@ -177,6 +177,7 @@ def __init__(self, address: str, ethereum_client: EthereumClient): def from_bytes(cls, encoded_multisend_txs: Union[str, bytes]) -> List[MultiSendTx]: """ Decodes one or more multisend transactions from `bytes transactions` (Abi decoded) + :param encoded_multisend_txs: :return: List of MultiSendTxs """ @@ -206,6 +207,7 @@ def from_transaction_data( ) -> List[MultiSendTx]: """ Decodes multisend transactions from transaction data (ABI encoded with selector) + :return: """ try: @@ -222,6 +224,7 @@ def deploy_contract( ) -> EthereumTxSent: """ Deploy proxy factory contract + :param ethereum_client: :param deployer_account: Ethereum Account :return: deployed contract address @@ -249,6 +252,7 @@ def get_contract(self): def build_tx_data(self, multi_send_txs: List[MultiSendTx]) -> bytes: """ Txs don't need to be valid to get through + :param multi_send_txs: :param sender: :return: diff --git a/gnosis/safe/safe_tx.py b/gnosis/safe/safe_tx.py index 46e0eeb51..69d36ce43 100644 --- a/gnosis/safe/safe_tx.py +++ b/gnosis/safe/safe_tx.py @@ -81,16 +81,16 @@ def __init__( self, ethereum_client: EthereumClient, safe_address: str, - to: str, + to: Optional[str], value: int, data: bytes, operation: int, safe_tx_gas: int, base_gas: int, gas_price: int, - gas_token: str, - refund_receiver: str, - signatures: bytes = b"", + gas_token: Optional[str], + refund_receiver: Optional[str], + signatures: Optional[bytes] = None, safe_nonce: Optional[int] = None, safe_version: str = None, chain_id: Optional[int] = None, @@ -127,7 +127,7 @@ def __init__( self.gas_price = gas_price self.gas_token = gas_token or NULL_ADDRESS self.refund_receiver = refund_receiver or NULL_ADDRESS - self.signatures = signatures + self.signatures = signatures or b"" self._safe_nonce = safe_nonce self._safe_version = safe_version self._chain_id = chain_id