Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow custom handling of isValidSignature #172

Closed
rmeissner opened this issue Jan 20, 2020 · 1 comment
Closed

Allow custom handling of isValidSignature #172

rmeissner opened this issue Jan 20, 2020 · 1 comment

Comments

@rmeissner
Copy link
Member

The fallback manager logic allows it to implement custom handling of data calls to the contract (that do not call existing methods). But it is not possible to implement alternative validation schemes for isValidSignature therefore it would be nice to have a callback for that.

Alternative

Remove isValidSignature from the core contract and add it to the fallback manager logic
@rmeissner rmeissner modified the milestone: contracts-safe-1.2.0 Apr 10, 2020
@rmeissner rmeissner added the future Features for next major contract version label Apr 19, 2020
@rmeissner
Copy link
Member Author

see #223

@rmeissner rmeissner removed the future Features for next major contract version label Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rmeissner