You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the getSafeWithOwners test utility function accepts all the necessary parameters as standalone variables. In general, it's a good practice in the JavaScript world to use an object instead when the number of parameters exceeds a certain threshold to ease the addition of new ones.
For more context, see the discussion and pain of introducing new parameters here #759 (comment)
Proposed solution
Use an object to accept all the necessary parameters for safe setup
Bonus points: find other functions that would benefit from this
Alternatives
Don't do anything
The text was updated successfully, but these errors were encountered:
Context/issue
Currently, the getSafeWithOwners test utility function accepts all the necessary parameters as standalone variables. In general, it's a good practice in the JavaScript world to use an object instead when the number of parameters exceeds a certain threshold to ease the addition of new ones.
For more context, see the discussion and pain of introducing new parameters here #759 (comment)
Proposed solution
Use an object to accept all the necessary parameters for safe setup
Bonus points: find other functions that would benefit from this
Alternatives
Don't do anything
The text was updated successfully, but these errors were encountered: