Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor getSafeWithOwners function to accept an object as an argument #780

Closed
mmv08 opened this issue Jul 3, 2024 · 0 comments · Fixed by #796
Closed

Refactor getSafeWithOwners function to accept an object as an argument #780

mmv08 opened this issue Jul 3, 2024 · 0 comments · Fixed by #796
Assignees

Comments

@mmv08
Copy link
Member

mmv08 commented Jul 3, 2024

Context/issue

Currently, the getSafeWithOwners test utility function accepts all the necessary parameters as standalone variables. In general, it's a good practice in the JavaScript world to use an object instead when the number of parameters exceeds a certain threshold to ease the addition of new ones.

For more context, see the discussion and pain of introducing new parameters here #759 (comment)

Proposed solution

Use an object to accept all the necessary parameters for safe setup
Bonus points: find other functions that would benefit from this

Alternatives

Don't do anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants